Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge extended reference handling back into primary experimental branch. #20585

Closed
wants to merge 14 commits into from
Closed

Merge extended reference handling back into primary experimental branch. #20585

wants to merge 14 commits into from

Conversation

lallydd
Copy link

@lallydd lallydd commented Nov 2, 2023

Added more tracking (for future diagnostics) and tracked down the last known reference leaks.

Still needs policy controls, cleanup, and performance enhancements. But we can use this to verify
that it'll scale to high context/metric counts.

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@lallydd lallydd requested review from a team as code owners November 2, 2023 12:31
@bits-bot
Copy link
Collaborator

bits-bot commented Nov 2, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cit-pr-commenter cit-pr-commenter
Copy link

cit-pr-commenter bot commented Nov 2, 2023 •
edited
Loading

Go Package Import Differences

Baseline: 57e39ea
Comparison: 486aa88

binaryosarchchange
agentlinuxamd64
+9, -0 
+github.com/hashicorp/golang-lru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/message
+golang.org/x/text/message/catalog
+hash/maphash
agentlinuxarm64
+9, -0 
+github.com/hashicorp/golang-lru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/message
+golang.org/x/text/message/catalog
+hash/maphash
agentwindowsamd64
+13, -0 
+github.com/hashicorp/golang-lru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/language
+golang.org/x/text/internal/language/compact
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/internal/tag
+golang.org/x/text/language
+golang.org/x/text/message
+golang.org/x/text/message/catalog
agentwindows386
+13, -0 
+github.com/hashicorp/golang-lru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/language
+golang.org/x/text/internal/language/compact
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/internal/tag
+golang.org/x/text/language
+golang.org/x/text/message
+golang.org/x/text/message/catalog
agentdarwinamd64
+13, -0 
+github.com/hashicorp/golang-lru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/language
+golang.org/x/text/internal/language/compact
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/internal/tag
+golang.org/x/text/language
+golang.org/x/text/message
+golang.org/x/text/message/catalog
agentdarwinarm64
+13, -0 
+github.com/hashicorp/golang-lru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/language
+golang.org/x/text/internal/language/compact
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/internal/tag
+golang.org/x/text/language
+golang.org/x/text/message
+golang.org/x/text/message/catalog
iot-agentlinuxamd64
+15, -0 
+github.com/hashicorp/golang-lru
+github.com/hashicorp/golang-lru/simplelru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/language
+golang.org/x/text/internal/language/compact
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/internal/tag
+golang.org/x/text/language
+golang.org/x/text/message
+golang.org/x/text/message/catalog
+hash/maphash
iot-agentlinuxarm64
+15, -0 
+github.com/hashicorp/golang-lru
+github.com/hashicorp/golang-lru/simplelru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/language
+golang.org/x/text/internal/language/compact
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/internal/tag
+golang.org/x/text/language
+golang.org/x/text/message
+golang.org/x/text/message/catalog
+hash/maphash
heroku-agentlinuxamd64
+14, -0 
+github.com/hashicorp/golang-lru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/language
+golang.org/x/text/internal/language/compact
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/internal/tag
+golang.org/x/text/language
+golang.org/x/text/message
+golang.org/x/text/message/catalog
+hash/maphash
cluster-agentlinuxamd64
+14, -0 
+github.com/hashicorp/golang-lru
+github.com/hashicorp/golang-lru/simplelru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/language
+golang.org/x/text/internal/language/compact
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/internal/tag
+golang.org/x/text/language
+golang.org/x/text/message
+golang.org/x/text/message/catalog
cluster-agentlinuxarm64
+14, -0 
+github.com/hashicorp/golang-lru
+github.com/hashicorp/golang-lru/simplelru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/language
+golang.org/x/text/internal/language/compact
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/internal/tag
+golang.org/x/text/language
+golang.org/x/text/message
+golang.org/x/text/message/catalog
cluster-agent-cloudfoundrylinuxamd64
+15, -0 
+github.com/hashicorp/golang-lru
+github.com/hashicorp/golang-lru/simplelru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/language
+golang.org/x/text/internal/language/compact
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/internal/tag
+golang.org/x/text/language
+golang.org/x/text/message
+golang.org/x/text/message/catalog
+hash/maphash
cluster-agent-cloudfoundrylinuxarm64
+15, -0 
+github.com/hashicorp/golang-lru
+github.com/hashicorp/golang-lru/simplelru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/language
+golang.org/x/text/internal/language/compact
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/internal/tag
+golang.org/x/text/language
+golang.org/x/text/message
+golang.org/x/text/message/catalog
+hash/maphash
dogstatsdlinuxamd64
+17, -0 
+github.com/hashicorp/golang-lru
+github.com/hashicorp/golang-lru/simplelru
+golang.org/x/exp/constraints
+golang.org/x/exp/slices
+golang.org/x/text/feature/plural
+golang.org/x/text/internal
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/language
+golang.org/x/text/internal/language/compact
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/internal/tag
+golang.org/x/text/language
+golang.org/x/text/message
+golang.org/x/text/message/catalog
+hash/maphash
dogstatsdlinuxarm64
+17, -0 
+github.com/hashicorp/golang-lru
+github.com/hashicorp/golang-lru/simplelru
+golang.org/x/exp/constraints
+golang.org/x/exp/slices
+golang.org/x/text/feature/plural
+golang.org/x/text/internal
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/language
+golang.org/x/text/internal/language/compact
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/internal/tag
+golang.org/x/text/language
+golang.org/x/text/message
+golang.org/x/text/message/catalog
+hash/maphash
process-agentlinuxamd64
+14, -0 
+github.com/hashicorp/golang-lru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/language
+golang.org/x/text/internal/language/compact
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/internal/tag
+golang.org/x/text/language
+golang.org/x/text/message
+golang.org/x/text/message/catalog
+hash/maphash
process-agentlinuxarm64
+14, -0 
+github.com/hashicorp/golang-lru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/language
+golang.org/x/text/internal/language/compact
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/internal/tag
+golang.org/x/text/language
+golang.org/x/text/message
+golang.org/x/text/message/catalog
+hash/maphash
process-agentwindowsamd64
+13, -0 
+github.com/hashicorp/golang-lru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/language
+golang.org/x/text/internal/language/compact
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/internal/tag
+golang.org/x/text/language
+golang.org/x/text/message
+golang.org/x/text/message/catalog
process-agentdarwinamd64
+13, -0 
+github.com/hashicorp/golang-lru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/language
+golang.org/x/text/internal/language/compact
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/internal/tag
+golang.org/x/text/language
+golang.org/x/text/message
+golang.org/x/text/message/catalog
process-agentdarwinarm64
+13, -0 
+github.com/hashicorp/golang-lru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/language
+golang.org/x/text/internal/language/compact
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/internal/tag
+golang.org/x/text/language
+golang.org/x/text/message
+golang.org/x/text/message/catalog
heroku-process-agentlinuxamd64
+14, -0 
+github.com/hashicorp/golang-lru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/language
+golang.org/x/text/internal/language/compact
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/internal/tag
+golang.org/x/text/language
+golang.org/x/text/message
+golang.org/x/text/message/catalog
+hash/maphash
security-agentlinuxamd64
+15, -0 
+github.com/hashicorp/golang-lru
+github.com/hashicorp/golang-lru/simplelru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/language
+golang.org/x/text/internal/language/compact
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/internal/tag
+golang.org/x/text/language
+golang.org/x/text/message
+golang.org/x/text/message/catalog
+hash/maphash
security-agentlinuxarm64
+15, -0 
+github.com/hashicorp/golang-lru
+github.com/hashicorp/golang-lru/simplelru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/language
+golang.org/x/text/internal/language/compact
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/internal/tag
+golang.org/x/text/language
+golang.org/x/text/message
+golang.org/x/text/message/catalog
+hash/maphash
serverlesslinuxamd64
+15, -0 
+github.com/hashicorp/golang-lru
+github.com/hashicorp/golang-lru/simplelru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/language
+golang.org/x/text/internal/language/compact
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/internal/tag
+golang.org/x/text/language
+golang.org/x/text/message
+golang.org/x/text/message/catalog
+hash/maphash
serverlesslinuxarm64
+15, -0 
+github.com/hashicorp/golang-lru
+github.com/hashicorp/golang-lru/simplelru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/language
+golang.org/x/text/internal/language/compact
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/internal/tag
+golang.org/x/text/language
+golang.org/x/text/message
+golang.org/x/text/message/catalog
+hash/maphash
system-probelinuxamd64
+10, -0 
+github.com/hashicorp/golang-lru
+github.com/hashicorp/golang-lru/simplelru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/message
+golang.org/x/text/message/catalog
+hash/maphash
system-probelinuxarm64
+10, -0 
+github.com/hashicorp/golang-lru
+github.com/hashicorp/golang-lru/simplelru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/message
+golang.org/x/text/message/catalog
+hash/maphash
system-probewindowsamd64
+14, -0 
+github.com/hashicorp/golang-lru
+github.com/hashicorp/golang-lru/simplelru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/language
+golang.org/x/text/internal/language/compact
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/internal/tag
+golang.org/x/text/language
+golang.org/x/text/message
+golang.org/x/text/message/catalog
trace-agentlinuxamd64
+15, -0 
+github.com/hashicorp/golang-lru
+github.com/hashicorp/golang-lru/simplelru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/language
+golang.org/x/text/internal/language/compact
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/internal/tag
+golang.org/x/text/language
+golang.org/x/text/message
+golang.org/x/text/message/catalog
+hash/maphash
trace-agentlinuxarm64
+15, -0 
+github.com/hashicorp/golang-lru
+github.com/hashicorp/golang-lru/simplelru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/language
+golang.org/x/text/internal/language/compact
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/internal/tag
+golang.org/x/text/language
+golang.org/x/text/message
+golang.org/x/text/message/catalog
+hash/maphash
trace-agentwindowsamd64
+14, -0 
+github.com/hashicorp/golang-lru
+github.com/hashicorp/golang-lru/simplelru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/language
+golang.org/x/text/internal/language/compact
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/internal/tag
+golang.org/x/text/language
+golang.org/x/text/message
+golang.org/x/text/message/catalog
trace-agentwindows386
+14, -0 
+github.com/hashicorp/golang-lru
+github.com/hashicorp/golang-lru/simplelru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/language
+golang.org/x/text/internal/language/compact
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/internal/tag
+golang.org/x/text/language
+golang.org/x/text/message
+golang.org/x/text/message/catalog
trace-agentdarwinamd64
+14, -0 
+github.com/hashicorp/golang-lru
+github.com/hashicorp/golang-lru/simplelru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/language
+golang.org/x/text/internal/language/compact
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/internal/tag
+golang.org/x/text/language
+golang.org/x/text/message
+golang.org/x/text/message/catalog
trace-agentdarwinarm64
+14, -0 
+github.com/hashicorp/golang-lru
+github.com/hashicorp/golang-lru/simplelru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/language
+golang.org/x/text/internal/language/compact
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/internal/tag
+golang.org/x/text/language
+golang.org/x/text/message
+golang.org/x/text/message/catalog
heroku-trace-agentlinuxamd64
+15, -0 
+github.com/hashicorp/golang-lru
+github.com/hashicorp/golang-lru/simplelru
+golang.org/x/text/feature/plural
+golang.org/x/text/internal
+golang.org/x/text/internal/catmsg
+golang.org/x/text/internal/format
+golang.org/x/text/internal/language
+golang.org/x/text/internal/language/compact
+golang.org/x/text/internal/number
+golang.org/x/text/internal/stringset
+golang.org/x/text/internal/tag
+golang.org/x/text/language
+golang.org/x/text/message
+golang.org/x/text/message/catalog
+hash/maphash

@jeremy-hanna
Copy link
Contributor

👋 is this ready for review or should this be a draft PR?

@lallydd
Copy link
Author

lallydd commented Nov 7, 2023

👋 is this ready for review or should this be a draft PR?

Oh I'll make it a draft PR. I want to verify it passes CI/CD and start running the benchmarks.

@lallydd lallydd marked this pull request as draft November 7, 2023 18:15
@lallydd lallydd removed request for a team November 7, 2023 18:49
@lallydd lallydd marked this pull request as ready for review November 19, 2023 15:20
@lallydd lallydd requested review from a team as code owners November 19, 2023 15:20
@lallydd
Copy link
Author

lallydd commented Nov 19, 2023

This is a reference PR for what #20943 and its successive 2 will result in when complete. This branch contains all planned changes, lally/exp-mem held a subset.

@lallydd lallydd closed this Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lallydd @bits-bot @jeremy-hanna